On Sat, Mar 8, 2014 at 1:11 PM, Torsten Bögershausen <tboegi@xxxxxx> wrote: > On 2014-03-08 03.47, Nguyễn Thái Ngọc Duy wrote: >> We've been avoiding PATH_MAX whenever possible. This patch makes >> get_pathname() return a strbuf and updates the callers to take >> advantage of this. The code is simplified as we no longer need to >> worry about buffer overflow. >> >> vsnpath() behavior is changed slightly: previously it always clears > Minor question: > Is the function name vsnpath() appropriate any more ? > How about renaming the function into strbuf_vaddpath() ? It is renamed in 04/28 to do_git_path(). -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html