Re: [PATCH v4] commit.c: use skip_prefix() instead of starts_with()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster <at> pobox.com> writes:

> 
> Junio C Hamano <gitster <at> pobox.com> writes:
> 
> >> +		found = skip_prefix(buf, sigcheck_gpg_status[i].check + 1);
> >> +		if(!found) {
> 
> Missing SP between the control keyword and parenthesized expression
> the keyword uses.
> 
> I've fixed this (and the broken indentation) locally and queued the
> result to 'pu', so no need to resend to correct this one.
> 
> Thanks.
> 
> 

Sorry about the indentation, it was due to not setting the tab to eight
spaces. I found your mail late, so I had already
sent a revised patch [1]. Please ignore that mail.

Also , what should be my next step ,should I present a rough draft of a
proposal , or tackle other bugs on the mailing list?

Thanks for the suggestions and advice,

Regards,
Tanay Abhra.

[1] http://article.gmane.org/gmane.comp.version-control.git/243395

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]