2014-03-03 2:42 GMT+08:00 Eric Sunshine <sunshine@xxxxxxxxxxxxxx>:
> On Sun, Mar 2, 2014 at 2:30 AM, Sun He <sunheehnus@xxxxxxxxx> wrote:
>> 'pack_tmp_name' is the subject of the utime() check, so report it in the
>> warning, not the uninitialized 'tmpname'
>>
>> Signed-off-by: Sun He <sunheehnus@xxxxxxxxx>
>> ---
>>
>> Changing the subject and adding valid information as tutored by
>> Eric Sunshine.
>> Thanks to him.
>>
>> builtin/pack-objects.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
>> index c733379..4922ce5 100644
>> --- a/builtin/pack-objects.c
>> +++ b/builtin/pack-objects.c
>> @@ -823,7 +823,7 @@ static void write_pack_file(void)
>> utb.modtime = --last_mtime;
>> if (utime(pack_tmp_name, &utb) < 0)
>> warning("failed utime() on %s: %s",
>> - tmpname, strerror(errno));
>> + pack_tmp_name, strerror(errno));
>> }
>>
>> /* Enough space for "-<sha-1>.pack"? */
>> --
>> 1.9.0.138.g2de3478.dirty
>
> Nicely done. Everything is where it ought to be.
>
> As this is an actual bug fix (not just a GSoC microproject):
>
> Reviewed-by: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>
Thank you so much for everything you have done.
I am honored to do this with all your support and kindness.
Regards，
He Sun
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html