On Sun, Mar 2, 2014 at 3:37 PM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > On Sat, Mar 1, 2014 at 9:53 PM, Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> wrote: >> This is "rev-list style", where people can do "git rev-list -3" in >> addition to "git rev-list HEAD~3". A lot of commands are driven by the >> revision machinery and also accept this form. This addition to rebase >> is just for convenience. >> >> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> >> --- >> diff --git a/git-rebase.sh b/git-rebase.sh >> index 5f6732b..33face1 100755 >> --- a/git-rebase.sh >> +++ b/git-rebase.sh >> @@ -342,6 +346,11 @@ do >> esac >> shift >> done >> +if [ -n "$NUM" ] > > With the exception of one errant "if [...]", git-rebase.sh uniformly > uses "if test ...". Besides that and three more "if [...]" in git-rebase--interactive.sh, git-rebase*.sh uses "if test..." only. Will reroll with a cleanup patch to make them all "if test.." -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html