On Thu, Feb 20, 2014 at 6:26 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Is there a reason not to do just an equivalent of > > #define git_pathdup mkpathdup > > and be done with it? Am I missing something? > They have a subtle difference: mkpathdup() calls cleanup_path() while git_pathdup() does not. Without auditing all call sites, we can't be sure this difference is insignificant. So I keep both functions separate for now. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html