Re: [PATCH v2 09/11] reflog-walk.c: use ALLOC_GROW() instead of inline code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Duy Nguyen <pclouds@xxxxxxxxx> writes:

> On Fri, Feb 28, 2014 at 4:46 PM, Dmitry S. Dolzhenko
> <dmitrys.dolzhenko@xxxxxxxxx> wrote:
>> Affected functions: read_one_reflog(), add_commit_info()
>
> We can usually see this from @@ line so it's not really needed to
> describe. Same comment for a few other patches.

Not everybody always reads "git log" with "-p".  It is good to see
what are changed mentioned somewhere.

I prefer to see full sentences, though ;-)

	Subject: reflog-walk.c: use ALLOC_GROW()

	read_one_reflog() and add_commit_info() open-codes reallocation;
        use ALLOC_GROW() instead.

or something.  But that is minor.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]