On Fri, Feb 28, 2014 at 7:14 PM, Jacopo Notarstefano <jacopo.notarstefano@xxxxxxxxx> wrote: >> Nice. new_ref is passed in install_branch_config() in latest code. I >> guess you already made sure this function did not make any assumption >> about new_ref's length? >> > > The function install_branch_config uses the strbuf, as I wrote in the > commit message. The contents of this buffer are then fed to > git_config_set, which, after a few more function calls, parses the key > with git_config_parse_key. This function does not rely on any > assumptions (as far as I can tell!) on the name's length, and > allocates enough space for it in > https://github.com/git/git/blob/master/config.c#L1462. Thanks for checking! -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html