Re: [PATCH 17/19] Portable alloca for Git

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

On Mon, 24 Feb 2014 20:21:49 +0400, Kirill Smelkov <kirr@xxxxxxxxxx> wrote:
> Both autoconf and config.mak.uname configurations were updated. For
> autoconf, we are not bothering considering cases, when no alloca.h is
> available, but alloca() works some other way - its simply alloca.h is
> available and works or not, everything else is deep legacy.

Sounds good for GNU Hurd, or any system using glibc (but have not
explicitly tested your patch).

> For config.mak.uname, I've tried to make my almost-sure guess for where
> alloca() is available, but since I only have access to Linux it is the
> only change I can be sure about myself, with relevant to other changed
> systems people Cc'ed.

> diff --git a/config.mak.uname b/config.mak.uname
> index 7d31fad..71602ee 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -239,6 +243,7 @@ ifeq ($(uname_S),AIX)
>  endif
>  ifeq ($(uname_S),GNU)
>  	# GNU/Hurd
> +	HAVE_ALLOCA_H = YesPlease
>  	NO_STRLCPY = YesPlease
>  	NO_MKSTEMPS = YesPlease
>  	HAVE_PATHS_H = YesPlease

Acked-by: Thomas Schwinge <thomas@xxxxxxxxxxxxxxxx> (GNU Hurd changes)


Grüße,
 Thomas

Attachment: pgpmecgMoQ28M.pgp
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]