> Hmm. Looks like it is only a problem if you are calling a shell function > (since it is the shell function's trace output you are seeing). So this > test would be OK as-is Indeed, this test passes when run locally, even using "sh -x". I would be in favor of using test_i18ngrep, but it seems like this test file overwhelmingly uses test_(i18n)cmp, even when inspecting stderr output. Making double-sure that all tests pass when run with "sh -x" seems like a larger endeavor. Of course, I'd be happy to submit several patches if there's support for such a change. But as Peff points out it will be a large diff. - Brian Gesiak On Fri, Feb 28, 2014 at 4:26 PM, Jeff King <peff@xxxxxxxx> wrote: > On Fri, Feb 28, 2014 at 02:14:01AM -0500, Jeff King wrote: > >> I didn't think we bothered to make "sh -x" work robustly. I don't mind >> if we do, but "git grep -E 'test_(i18n)?cmp .*err" shows many potential >> problem spots. > > Just for fun: > > cd t > make SHELL_PATH="sh -x" prove > > causes 326 test failures across 43 scripts. That's slightly misleading, > because 200 of the failures are all in t0008, and updating one function > would probably clear up all of them. > > -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html