On 2/8/07, Andy Parkins <andyparkins@xxxxxxxxx> wrote:
On Thursday 2007 February 08 08:39, Marco Costalba wrote: > Regarding "Monospace" it should be changeable with Settings menu and > should apply _only_ to fixed space font viewers, in our case only > patch viewer and file content viewer. The log message was the one I changed. Having the log message in variable width breaks any ascii-art in the message. I completely agree about pulling the setting from the config. I'll see if I can find that and post a further patch. > If you see Monospace applied to list view or any other widget apart > from the above mentioned ones then it's a bug. True. I used "Monospaced" as the font as that defaults to the system-wide monospaced font; however it's pretty poor form. I raise my hand - shoot me :-) As I say, I'll try and do better and send a new patch.
I have applied and pushed all your patches. BTW you are referring to qgit4 at Pasky http://repo.or.cz/ site, not the stable qgit in kernel.org repo! I didn't got it unti I tried to apply the patches :-) Hint: Regarding application 'fixed width' font please refer to TYPE_WRITER_FONT variable defined in common.h in your new patch, this is where user choosen font is stored. Not-fixed-width font is set with qtconfig tool. Marco P.S: Yes, I have noted this Qt::convertFromPlainText() misbehaviour, but I don't know if are the spaces that are not escaped correctly by the function or the QTextEdit rendering engine that eats the (escaped) spaces anyway. P.P.S: Give a try to Bitstream Vera Sans Mono as fixed width font, it's muuuuuch better then Monospace IMHO ;-) - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html