Re: [PATCH] remote: handle pushremote config in any order order

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> writes:

> Jeff King <peff@xxxxxxxx> writes:
>
>> Yes, with a few exceptions, we usually try to make the ordering in the
>> config file irrelevant. This is a bug. The patch below should fix it.
>
> Looks good.  Thanks.

>> diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh
>> index 926e7f6..1309c4d 100755
>> --- a/t/t5516-fetch-push.sh
>> +++ b/t/t5516-fetch-push.sh
>> @@ -536,6 +536,18 @@ test_expect_success 'push with config branch.*.pushremote' '
>>  	check_push_result down_repo $the_commit heads/master
>>  '
>>  
>> +test_expect_success 'branch.*.pushremote config order is irrelevant' '
>> +	mk_test one_repo heads/master &&
>> +	mk_test two_repo heads/master &&
>> +	test_config remote.one.url one_repo &&
>> +	test_config remote.two.url two_repo &&
>> +	test_config branch.master.pushremote two_repo &&
>> +	test_config remote.pushdefault one_repo &&
>> +	git push &&
>> +	check_push_result one_repo $the_first_commit heads/master &&
>> +	check_push_result two_repo $the_commit heads/master
>> +'
>> +

This test however does not pass in the Git 2.0 world, without having
this line:

       test_config push.default matching &&

immediately before "git push".

Am I missing something?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]