Re: [PATCH] tag: support --sort=version

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 21, 2014 at 06:58:16PM +0700, Duy Nguyen wrote:

> >   --sort=[-][comparison:]field
> [...]
> Why not reversed order? So its syntax could be
> 
> [ "-" ] FIELD [ ":" [ "version" | "v" ] ]
> 
> It fits better to current f-e-r syntax where modifiers are after the
> colon. And it avoids the possibility that someone adds field "version"
> and we can't tell what "version" is what.

I find my version a bit more obvious, for two reasons:

  1. "version" here is not a modifier of the field name, it is a
     modifier of the sort. You cannot use it in non-sort contexts (like
     --format), and you cannot order it like other modifiers (you cannot
     say "refname:version:short", only "refname:short:version").

  2. There are actually two sort-modifiers: "-" for ordering, and then a
     comparator. In your proposal, they are split, whereas in mine, they
     are next to each other.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]