Junio C Hamano <gitster@xxxxxxxxx> writes: > John Keeping <john@xxxxxxxxxxxxx> writes: > >> There are two problems here: >> >> 1) If no argument is provided, then the command segfaults >> 2) The argument is not consumed, so there will be excess output >> >> Fix both of these in one go by restructuring the handler for this >> option. >> >> Reported-by: Daniel Hahler <genml+git-2014@xxxxxxxxxx> >> Signed-off-by: John Keeping <john@xxxxxxxxxxxxx> >> --- > > Looks sensible; thanks. Ehh, I spoke too fast. Don't we already have this queued as a43219f2 (rev-parse: check i before using argv[i] against argc, 2014-01-28)? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html