On Wed, Feb 19, 2014 at 3:59 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Let's do something like this first and then later make --depth
> configurable just like --width, perhaps? For "aggressive", I think
> the default width (hardcoded to 250 but configurable) is a bit too
> narrow.
>
> builtin/gc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/gc.c b/builtin/gc.c
> index 6be6c8d..0d010f0 100644
> --- a/builtin/gc.c
> +++ b/builtin/gc.c
> @@ -204,7 +204,7 @@ int cmd_gc(int argc, const char **argv, const char *prefix)
>
> if (aggressive) {
> argv_array_push(&repack, "-f");
> - argv_array_push(&repack, "--depth=250");
> + argv_array_push(&repack, "--depth=20");
> if (aggressive_window > 0)
> argv_array_pushf(&repack, "--window=%d", aggressive_window);
> }
Lower depth than default (50) does not sound "aggressive" to me, at
least from disk space utilization. I agree it should be configurable
though.
--
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html