We are guaranteed that 'nst' is non-null because it is allocated with
xmalloc(), and in fact we rely on this three lines later by
unconditionally dereferencing it.
Signed-off-by: John Keeping <john@xxxxxxxxxxxxx>
---
streaming.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/streaming.c b/streaming.c
index d7c9f32..8a7135d 100644
--- a/streaming.c
+++ b/streaming.c
@@ -151,10 +151,7 @@ struct git_istream *open_istream(const unsigned char *sha1,
}
if (filter) {
/* Add "&& !is_null_stream_filter(filter)" for performance */
- struct git_istream *nst = attach_stream_filter(st, filter);
- if (!nst)
- close_istream(st);
- st = nst;
+ st = attach_stream_filter(st, filter);
}
*size = st->size;
--
1.9.rc0.187.g6292fff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html