On Tue, Feb 11, 2014 at 10:57:22AM -0800, Junio C Hamano wrote: > > - git stash doesn't use --index as default > > http://article.gmane.org/gmane.comp.version-control.git/235892 > > I tend to think "git stash" was designed to work this way from day > one. Right. The thing that bothers me is the data loss of: echo 1 >foo git add foo echo 2 >foo git stash git stash pop The content in "1" is stashed, but gets lost on the apply, and our pop drops the stash. > > - using git commit-tree with "-F -" adds trailing newlines > > http://article.gmane.org/gmane.comp.version-control.git/236583 > > According to the initial commit that introduced this option, it > deliberately calls strbuf_complete_line() to make sure we do not > leave an incomplete line at the end. Yeah, I think this one is a non-bug. I hadn't read it carefully but the "trailing newlines" made me think it was adding multiple extra blank lines. But it looks like it is just the normal strbuf_complete_line, and that is the right thing to be doing (it has _never_ been encouraged to have a commit message that does not have a newline at all, and I think stripspace has enforced that from day one). > Many of the other items in your "bugs" section seem to be worth > fixing. As I mentioned elsewhere, I've yet to see the full results of the hackday. Hopefully soon. :) -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html