On Wed, Feb 12, 2014 at 11:10:49PM +0000, Thomas Adam wrote:
> On 12 February 2014 20:59, Jeff King <peff@xxxxxxxx> wrote:
> > +sub decode {
> > + my $orig = shift;
> > + my $decoded = eval { decode_utf8($orig, Encode::FB_CROAK) };
> > + return defined $decoded ?
>
> I'd still advocate checking $@ here, rather than the defined $decoded check.
I don't mind changing it, but for my edification, what is the advantage?
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html