I'll locally fix up these style issues before commenting on the patch. Thanks. ERROR: space required after that ',' (ctx:VxV) #78: FILE: builtin/count-objects.c:111: + struct pack_data pd = {0,0,0}; ^ ERROR: space required after that ',' (ctx:VxV) #78: FILE: builtin/count-objects.c:111: + struct pack_data pd = {0,0,0}; ^ ERROR: space required after that ',' (ctx:VxV) #171: FILE: builtin/fsck.c:683: + struct verify_packs_data vpd = {0,0,0}; ^ ERROR: space required after that ',' (ctx:VxV) #171: FILE: builtin/fsck.c:683: + struct verify_packs_data vpd = {0,0,0}; ^ ERROR: space required after that ',' (ctx:VxV) #541: FILE: builtin/pack-redundant.c:591: + struct add_pack_data apd = {filename,0,NULL}; ^ ERROR: space required after that ',' (ctx:VxV) #541: FILE: builtin/pack-redundant.c:591: + struct add_pack_data apd = {filename,0,NULL}; ^ ERROR: space required after that ',' (ctx:VxV) #565: FILE: builtin/pack-redundant.c:604: + struct add_pack_data apd = {NULL,0,NULL}; ^ ERROR: space required after that ',' (ctx:VxV) #565: FILE: builtin/pack-redundant.c:604: + struct add_pack_data apd = {NULL,0,NULL}; ^ ERROR: space prohibited after that '-' (ctx:WxW) #726: FILE: pack-revindex.c:47: + num = - 1 - num; ^ ERROR: space required after that ',' (ctx:VxV) #901: FILE: sha1_name.c:195: + struct disambiguate_data d = {len,bin_pfx,ds}; ^ ERROR: space required after that ',' (ctx:VxV) #901: FILE: sha1_name.c:195: + struct disambiguate_data d = {len,bin_pfx,ds}; ^ total: 11 errors, 0 warnings, 781 lines checked -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html