Junio C Hamano <gitster@xxxxxxxxx> writes: > Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > >> Trailing spaces are invisible in most standard editors (*). "git diff" >> does show trailing spaces by default. But that does not help newly >> written .gitignore files. And trailing spaces are the source of >> frustration when writing .gitignore. >> >> So let's ignore them. Nobody sane would put a trailing space in file >> names. But we could be careful and do it in two steps: warn first, >> then ignore trailing spaces. Another option is merge two patches in >> one and be done with it. >> >> People can still quote trailing spaces, which will not be ignored (and >> much more visible). Quoting comes with a cost of doing fnmatch(). But > > Hmph, sorry but I fail to see why we need to incur cost for > fnmatch(). We read and parse the file and keep them as internal > strings, so your unquoting (and complaining the unquoted trailng > spaces) can be done at the parse time, while keeping the trailing > spaces the user explicitly told us to keep by quoting in the > internal string that we eventually feed fnmatch() with _after_ > unquoting, no? > > Puzzled... Heh, silly me. Yes, we _could_ parse and strip "\ " into " " if we wanted to, but we can just give "\ " and let fnmatch(3) do its thing, and that is the right thing to do for a rare corner case like this (i.e. deliberate trailing spaces). So I think I understand your reasoning, and I agree with it. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html