Re: gitweb.cgi bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Feb 8, 2014, at 8:37 AM, Dongsheng Song wrote:

> I have an git repo PROJECT.git, the full path is /srv/repo/git/PROJECT.git,
> when I set git_base_url_list in gitweb.conf:
> 
> @git_base_url_list = qw(https://192.168.30.239/repo/git
>                            git@192.168.30.239:repo/git);
> 
> I got the result:
> 
> https://192.168.30.239/repo/git/PROJECT.git
> git@192.168.30.239:/PROJECT.git
> 
> This is wrong, it should be (without the leading '/')
> git@192.168.30.239:PROJECT.git

There is no way to generate a fetch url of 'git@192.168.30.239:PROJECT.git' in gitweb.

If one of the base urls was 'git@192.168.30.239:.', then you could get a fetch URL of 'git@192.168.30.239:./PROJECT.git'

In general, though, I like to stay away from relative paths.  Weird things can happen, like HTTP works but SSH doesn't, because the home directory for SSH changed because you used a different user.

 - Andrew

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]