Re: [PATCH v5 10/14] trailer: execute command from 'trailer.<name>.command'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Christian Couder <chriscool@xxxxxxxxxxxxx> writes:

> +#define TRAILER_ARG_STRING "$ARG"

No need to support users who may want to use a string that happens
to match this substring literally as part of the command line?

>  struct trailer_item {
>  	struct trailer_item *previous;
>  	struct trailer_item *next;
> @@ -56,6 +60,13 @@ static inline int contains_only_spaces(const char *str)
>  	return !*s;
>  }
>  
> +static inline void strbuf_replace(struct strbuf *sb, const char *a, const char *b)

Same comment about "inline" for an earlier patch applies.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]