On Wed, Feb 05, 2014 at 09:17:47AM -0800, Junio C Hamano wrote: > Adrian Johnson <ajohnson@xxxxxxxxxxx> writes: > > >>> - "|[0-9][-+0-9#_.eE]" > >>> + "|[-+]?[0-9][0-9#_.aAbBcCdDeEfF]*([eE][+-]?[0-9_]+)?" > >> > >> This would match a lot wider than what I read you said you wanted to > >> match in your previous message. Does "-04##4_3_2Ee-9" count as a > >> number, for example, or can we just ignore such syntactically > >> incorrect sequence? > > > > Maybe I am misunderstanding the purpose of the word diff regexes. I > > thought the purpose of the word regex is to split lines into words, not > > determine what is syntactically correct. > > I agree that the purpose is former---So you could have just said > "the latter" ;-). > > Any other nitpick, anybody? Otherwise I'll queue this version. No nitpick here, I had the same thought as Adrian while reading the thread (and if somebody comes up with a real case where the output looks bad, we can iterate on it). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html