Junio C Hamano <gitster@xxxxxxxxx> writes:
> which I think is the prevalent style in our codebase. The same for
> the other loop we see in the new code below.
>
> - avoid assignments in conditionals when you do not have to.
commit a77a48c259d9adbe7779ca69a3432e493116b3fd
Author: Junio C Hamano <gitster@xxxxxxxxx>
Date: Tue Jan 28 13:55:59 2014 -0800
combine-diff: simplify intersect_paths() further
[...]
+ while ((p = *tail) != NULL) {
Because we can.
At any rate, I am not going to put any more work into this patch as it
is decidedly not worth the bad taste this discussion leaves in my mouth.
And I don't want any code marked as written by me that does not
correspond to what I'd be willing to write. So please make sure to put
any rewrites in a separate commit with different authorship.
Thanks
--
David Kastrup
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html