David Kastrup <dak@xxxxxxx> writes: > Junio C Hamano <gitster@xxxxxxxxx> writes: > >> David Kastrup <dak@xxxxxxx> writes: >> >>> Anybody know offhand what I should be including here? It looks like Git >>> has some fallback definitions of its own, so it's probably not just >>> <string.h> I should include? >> >> In general, no *.c files outside the compatibility layer should >> include anything "#include <system-header.h>", as there seem to be >> finicky systems that care about order of inclusion and feature macro >> definitions, all of which are meant to be handled by including >> git-compat-util.h as the very first thing. > > Ok, and that one's not yet in blame.c. Will include, thanks. No, don't. Some well-known *.h files of ourse, most notably cache.h, are known to include compat-util as the first thing, and that is what *.c files typically include. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html