On Sat, Jan 25, 2014 at 4:22 AM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > On Fri, Jan 24, 2014 at 8:40 AM, Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> wrote: >> diff --git a/t/t4010-diff-pathspec.sh b/t/t4010-diff-pathspec.sh >> index af5134b..167af53 100755 >> --- a/t/t4010-diff-pathspec.sh >> +++ b/t/t4010-diff-pathspec.sh >> @@ -110,4 +110,21 @@ test_expect_success 'diff-tree -r with wildcard' ' >> test_cmp expected result >> ' >> >> +test_expect_success 'setup submodules' ' >> + test_tick && Also the test_tick here. I thought I would need to match SHA-1 but I did not and still forgot to take this line out. >> + git init submod && >> + ( cd submod && test_commit first; ) && > > Unnecessary semicolon might confuse the reader into thinking something > unusual is going on here. > >> + git add submod && >> + git commit -m first && >> + ( cd submod && test_commit second; ) && > > Ditto. > >> + git add submod && >> + git commit -m second >> +' >> + >> +test_expect_success 'diff-cache ignores trailing slash on submodule path' ' >> + git diff --name-only HEAD^ submod >expect && >> + git diff --name-only HEAD^ submod/ >actual && >> + test_cmp expect actual >> +' >> + >> test_done -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html