Vicent Martí wrote: > On Fri, Jan 24, 2014 at 12:44 AM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: >>> +#if __BYTE_ORDER != __BIG_ENDIAN >> >> Is this portable? > > We explicitly set the __BYTE_ORDER macros in `compat/bswap.h`. In > fact, this preprocessor conditional is the same one that we use when > choosing what version of the `ntohl` macro to define, so that's why I > decided to use it here. Ah, thanks. Sorry I missed that. So feel free to add my reviewed-by to the patch without my tweak, too. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html