On Thu, Jan 23, 2014 at 11:56:43AM -0800, Jonathan Nieder wrote: > Jeff King wrote: > > > I think it was a bug waiting to surface if index v4 ever got wide use. > > Ah, ok. > > In that case I think git-compat-util.h should include something like > what block-sha1/sha1.c has: > > #if !defined(__i386__) && !defined(__x86_64__) && \ > !defined(_M_IX86) && !defined(_M_X64) && \ > !defined(__ppc__) && !defined(__ppc64__) && \ > !defined(__powerpc__) && !defined(__powerpc64__) && \ > !defined(__s390__) && !defined(__s390x__) > #define NEEDS_ALIGNED_ACCESS > #endif > > Otherwise we are relying on the person building to know their own > architecture intimately, which shouldn't be necessary. Yeah, I agree it would be nice to autodetect. I just didn't know what the right set of platforms was, and assumed people would tweak the Makefile knob as appropriate (though it is probably much easier to do so within the compiler, where we have the right architecture variables set). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html