On Thu, Jan 23, 2014 at 3:35 AM, Jens Lehmann <Jens.Lehmann@xxxxxx> wrote: > Am 20.01.2014 19:25, schrieb Paweł Sikora: >> i've noticed that 'git log submodule-dir' and 'git log submodule-dir/' >> return different results (module's head changes vs. nothing). is it a bug? >> looks like a trailing slash is a problem for git-log. > > I think this is a bug, and for example "git diff" has similar problems. > This is especially nasty as shell auto-completion adds the '/' at the > end. > > Duy, without having looked into the code myself yet: is this something > that might be easily fixed by using PATHSPEC_STRIP_SUBMODULE_SLASH*? I think so. But I dislike those preprocessing because it looks inefficient and the same change may be needed for other diff commands as well. Maybe we can handle this at diff or log-tree.c level. Will look further into it tonight. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html