Jeff King <peff@xxxxxxxx> writes: > On Mon, Jan 20, 2014 at 04:31:01PM -0500, Jeff King wrote: > >> diff --git a/t/perf/p0001-rev-list.sh b/t/perf/p0001-rev-list.sh >> index 4f71a63..b7258a7 100755 >> --- a/t/perf/p0001-rev-list.sh >> +++ b/t/perf/p0001-rev-list.sh >> @@ -14,4 +14,21 @@ test_perf 'rev-list --all --objects' ' >> git rev-list --all --objects >/dev/null >> ' >> >> +test_expect_success 'create new unreferenced commit' ' >> + git checkout --detach HEAD && >> + echo content >>file && >> + git add file && >> + git commit -m detached && >> + commit=$(git rev-parse --verify HEAD) && >> + git checkout - >> +' > > This is bad to be touching the repo and assuming it is non-bare. For > some reason I assumed that the perf suite made a copy of the repo, but > it doesn't. If you point to a bare repo via GIT_PERF_REPO, this part of > the test fails. It does make a copy, but with cp -Rl. I haven't actually ever tried what happens if you point it at a bare though. It *should* fail because it tries to cd $repo/.git, but if that was itself bare... -- Thomas Rast tr@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html