On Thu, Jan 2, 2014 at 10:08 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> Seems like the path to clone to is taken as-is from argv in >> cmd_clone(). So maybe another solution would be to replace all >> backslashes with forward slashes already there? > > That sounds like a workable alternative, and it might even be a > preferable solution but if and only if clone's use of the function > to create paths that lead to a new working tree location is the only > (ab)use of the function. That was what I meant when I said "it may > be that it is a bug in the specific caller". AFAIK, the function I think Dscho made valid points in his other mail that the better solution still is to make safe_create_leading_directories() actually safe, also regarding its arguments. -- Sebastian Schuberth -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html