On Fri, Jan 17, 2014 at 8:07 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Jonathan Nieder <jrnieder@xxxxxxxxx> writes:
>
>> Hi,
>>
>> Erik Faye-Lund wrote:
>>
>>> --- a/builtin/merge.c
>>> +++ b/builtin/merge.c
>>> @@ -367,7 +367,7 @@ static void squash_message(struct commit *commit, struct commit_list *remotehead
>>> sha1_to_hex(commit->object.sha1));
>>> pretty_print_commit(&ctx, commit, &out);
>>> }
>>> - if (write(fd, out.buf, out.len) < 0)
>>> + if (xwrite(fd, out.buf, out.len) < 0)
>>> die_errno(_("Writing SQUASH_MSG"));
>>
>> Shouldn't this use write_in_full() to avoid a silently truncated result? (*)
>
> Meaning this? If so, I think it makes sense.
>
Yeah, I think that's better. Thanks, both!
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html