Re: [PATCH 2/3] setup_pager: set MORE=R

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Jan 16, 2014, at 20:21, Jeff King wrote:
When we run the pager, we always set "LESS=R" to tell the
pager to pass through ANSI colors. On modern versions of
FreeBSD, the system "more" can do the same trick.
[snip]
diff --git a/pager.c b/pager.c
index 90d237e..2303164 100644
--- a/pager.c
+++ b/pager.c
@@ -87,6 +87,10 @@ void setup_pager(void)
		argv_array_push(&env, "LESS=FRSX");
	if (!getenv("LV"))
		argv_array_push(&env, "LV=-c");
+#ifdef PAGER_MORE_UNDERSTANDS_R
+	if (!getenv("MORE"))
+		argv_array_push(&env, "MORE=R");
+#endif

How about adding a leading "-" to both the LESS and MORE settings? Since you're in there patching... :)

The man page for more states:

"Options are also taken from the environment variable MORE (make sure to precede them with a dash (``-'')) but command line options will override them."

And while the less man page does not have that wording, it does show this:

  LESS="-options"; export LESS

and this:

  LESS="-Dn9.1$-Ds4.1"

So it looks like both LESS and MORE prefer to have their options start with a '-' more or less.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]