On Sun, Jan 12, 2014 at 6:03 PM, Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> wrote: > We are running out of on-disk ce_flags, Correction, we're not. I saw /* * Extended on-disk flags */ #define CE_INTENT_TO_ADD (1 << 29) #define CE_SKIP_WORKTREE (1 << 30) followed by /* CE_EXTENDED2 is for future extension */ #define CE_EXTENDED2 (1 << 31) and panicked, but on-disk flags could be added backward (e.g. bit 28, 27...). Anyway using extended flags means 2 extra bytes per entry for almost every entry in this case (and for index v5 it means redoing crc32 for almost every entry too when the bit is updated) so it may still be a good idea to keep the new flag separate. > so instead of extending > on-disk entry format again, "watched" flags are in-core only and > stored as extension instead. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html