Jeff King <peff@xxxxxxxx> writes: > On Mon, Jan 06, 2014 at 12:06:51PM -0800, Junio C Hamano wrote: > >> Unless you set @{u} to this new configuration, in which case the >> choice becomes dynamic depending on the current branch, but >> >> - if that is the only sane choice based on the current branch, why >> not use that as the default without having to set the >> configuration? >> >> - Or if that is still insufficient, don't we need branch.*.forkedFrom >> that is different from branch.*.merge, so that different branches >> you want to show "format-patch" output can have different >> reference points? > > Yeah, I had similar thoughts. I personally use "branch.*.merge" as > "forkedFrom", and it seems like we are going that way anyway with things > like "git rebase" and "git merge" defaulting to upstream. But then there > is "git push -u" and "push.default = upstream", which treats the > upstream config as something else entirely. > > So it seems like there is already some confusion, and either way we go, > thisis making it worse to some degree (I do not blame Ram, but rather he > has stumbled into a hidden sand pit that we have been building for the > past few years... :). > > I wonder if it is too late to try to clarify this dual usage. It kind of > seems like the push config is "this is the place I publish to". Which, > in many workflows, just so happens to be the exact same as the place you > forked from. Could we introduce a new branch.*.pushupstream variable > that falls back to branch.*.merge? Or is that just throwing more fuel on > the fire (more sand in the pit in my analogy, I guess). > > I admit I haven't thought it through yet, though. And even if it does > work, it may throw a slight monkey wrench in the proposed push.default > transition. Yeah, when I say "upstream", I never mean it as "where I publish". Your upstream is where you get others' work from. For a "push to somewhere for safekeeping or other people to look at" triangular workflow, it does not make any sense to treat that "I publish there" place as an upstream (hence having branch.*.remote pointing at that publishing point). Once you stop doing that, and instead using branch.*.remote = origin, and branch.*.merge = master, where 'origin' is not your publishing point, @{u} will again start making sense, I think. And I thought that is what setting "remote.pushdefault" to the publishing point repository was about. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html