Re: [PATCH 2/2] format-patch: introduce format.defaultTo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jonathan Nieder wrote:
>  1. Most config settings are in noun form: e.g.,
>     "[remote] pushDefault = foo".  That makes their names easy to guess
>     and makes them easy to talk about: I set the default remote for
>     pushing by changing the remote.pushdefault setting.
>
>     '[url "<foo>"] insteadOf' is an exception to that and a bit of an
>     aberration.
>
>     This new '[format] defaultTo' repeats the same end-with-a-preposition
>     mistake, while I think it would be better to learn from it.

I agree that it's somewhat unconventional to allow people to put a
<revision> as a configuration variable value, but I think it's useful.
url.<url>.insteadOf is incredibly useful, for instance.

>  2. Wouldn't a more natural default be @{u}..HEAD instead of relying on
>     the user to do the make-work of keeping a local branch that tracks
>     master up to date?

Like I said in my message to Junio, @{u} is not necessarily the "best"
default for all workflows, although you can fill that into
format.defaultTo.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]