I find what your patch does quite sensible, although the
split(/ *(?!:)/) magic might be a bit hard to read for the
uninitiated.
> + my $arg = 'git-repo-config';
> + $arg .= ' --bool' if ($o !~ /:$/);
> +
> + chomp(my $tmp = `$arg --get cvsimport.$key`);
> + if ($tmp && !($arg =~ / --bool / && $tmp eq 'false')) {
Can this =~ / --bool / ever match (note the SP after 'l')?
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html