On Fri, Jan 03, 2014 at 01:30:28PM +0530, Ramkumar Ramachandra wrote:
> To ease development, prioritize ./git-completion.bash over other
> standard system paths.
>
> Signed-off-by: Ramkumar Ramachandra <artagnon@xxxxxxxxx>
> ---
> contrib/completion/git-completion.zsh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh
> index fac5e71..6fca145 100644
> --- a/contrib/completion/git-completion.zsh
> +++ b/contrib/completion/git-completion.zsh
> @@ -30,10 +30,10 @@ if [ -z "$script" ]; then
> local -a locations
> local e
> locations=(
> + $(dirname ${funcsourcetrace[1]%:*})/git-completion.bash
> '/etc/bash_completion.d/git' # fedora, old debian
> '/usr/share/bash-completion/completions/git' # arch, ubuntu, new debian
> '/usr/share/bash-completion/git' # gentoo
> - $(dirname ${funcsourcetrace[1]%:*})/git-completion.bash
> )
> for e in $locations; do
> test -f $e && script="$e" && break
I'm not clear on this change. It looks like this loads
git-completion.bash from the same directory as git-completion.zsh. Is
this correct? Your commit message says "./", and if that's the case, it
has the same security problems as putting "." first in your PATH.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
Attachment:
signature.asc
Description: Digital signature