Re: [PATCH 9/9] trailer: add tests for "git interpret-trailers"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Christian Couder <chriscool@xxxxxxxxxxxxx> writes:

> +# Do not remove trailing spaces below!
> +cat >complex_message_trailers <<'EOF'
> +Fixes: 
> +Acked-by: 
> +Reviewed-by: 
> +Signed-off-by: 
> +EOF

Just a hint.  I think it is far safer and robust over time to do
something like this:

	sed -e 's/ Z$/ /' <<-\EOF
        Fixes: Z
        Acked-by: Z
        EOF

instead of a comment, which can warn human developers but does not
do anything to prevent their editors' auto-fix features from kicking
in.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]