Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
> Roman Kagan wrote:
>
> > Subversion serf backend in versions 1.8.5 and below has a bug that the
> > function creating the descriptor of a file change -- add_file() --
> > doesn't make a copy of its third argument when storing it on the
> > returned descriptor. As a result, by the time this field is used (in
> > transactions of file copying or renaming) it may well be released, and
> > the memory reused.
> >
> > One of its possible manifestations is the svn assertion triggering on an
> > invalid path, with a message
> >
> > svn_fspath__skip_ancestor: Assertion `svn_fspath__is_canonical(child_fspath)' failed.
> [...]
>
> Makes sense. Perhaps also worth mentioning that this is fixed by
> r1553376, but no need to reroll just for that.
Thanks all, I noted this in an addendum to the commit:
Subversion serf backend in versions 1.8.5 and below has a bug(*) that the
...
* [ew: fixed in Subversion r1553376 as noted by Jonathan Nieder]
> > Cc: Benjamin Pabst <benjamin.pabst85@xxxxxxxxx>
> > Cc: Eric Wong <normalperson@xxxxxxxx>
> > Cc: Jonathan Nieder <jrnieder@xxxxxxxxx>
>
> No need for these lines --- the mail header already keeps track of who
> is being cc-ed.
I don't mind seeing it in history. At least I've gotten accustomed to
it from the Linux kernel and tracking patch flow between dev -> stable
trees.
> > Signed-off-by: Roman Kagan <rkagan@xxxxxxx>
>
> Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
Signed-off-by: Eric Wong <normalperson@xxxxxxxx>
The following changes since commit 7794a680e63a2a11b73cb1194653662f2769a792:
Sync with 1.8.5.2 (2013-12-17 14:12:17 -0800)
are available in the git repository at:
git://git.bogomips.org/git-svn.git master
for you to fetch changes up to 2394e94e831991348688831a384b088a424c7ace:
git-svn: workaround for a bug in svn serf backend (2013-12-27 20:22:19 +0000)
----------------------------------------------------------------
Roman Kagan (1):
git-svn: workaround for a bug in svn serf backend
perl/Git/SVN/Editor.pm | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html