Re: [PATCH 2/3] prune_object_dir(): verify that path fits in the temporary buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 18, 2013 at 12:15:19PM -0800, Junio C Hamano wrote:

> > Thanks. Are you picking this up with a commit message, or did you want
> > me to re-send with the usual message/signoff?
> 
> I think this should be sufficient ;-)
> 
> -- >8 --
> From: Jeff King <peff@xxxxxxxx>
> Date: Tue, 17 Dec 2013 18:22:31 -0500
> Subject: [PATCH] builtin/prune.c: use strbuf to avoid having to worry about PATH_MAX
> 
> While at it, rename prune_tmp_object(), which used to be a helper to
> remove temporary files that were created to become loose object
> files, to prune_tmp_file(), as the function is also used to remove
> any random cruft whose name begins with tmp_ directly in .git/object
> or .git/object/pack directories these days.
> 
> Signed-off-by: Jeff King <peff@xxxxxxxx>
> Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>

Great, thanks. You might also want to stick a:

 Noticed-by: Michael Haggerty <mhagger@xxxxxxxxxxxx>

in there.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]