On Mon, Dec 16, 2013 at 1:53 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Samuel Bronson <naesten@xxxxxxxxx> writes: > Path-like parameters and values given by the end user should be > relative to the directory where the end user is (i.e. both -O > parameters in the above example name docs/orderfile). All Git > processes, even the ones that are capable of being run from a > subdirectory, are supposed to first chdir to the top level of the > working tree before doing anything else, and adjust the path-like > things they get from the end user from the command line accordingly. > By the time diffcore_order() to prepare_order() callchain is called, > we certainly should have passed that chdir already, so the value of > the option needs to be prepended with the "prefix" when parsed. > > The value specified for the diff.orderfile configuration can just be > a path relative to the top level of the working tree, I think. Oh, cool. So I'll just change the git_config_string() call to use git_config_pathname(), since the user might easily want to use ~ notation there, especially in a user-level setting ... -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html