On Sun, Dec 15, 2013 at 10:02 AM, Duy Nguyen <pclouds@xxxxxxxxx> wrote: > On Sun, Dec 15, 2013 at 3:35 PM, Torsten Bögershausen <tboegi@xxxxxx> wrote: >> If we really want to go away from PATH_MAX, is a hard-coded value of 4096 so attractive ? >> Because we can either >> >> a) Re-define PATH_MAX in git-compat-util.h >> b) Use an own #define in git-compat-util.h, like e.g. GIT_PATH_MAX >> c) Change the code to use a "strbuf" which can grow on demand. >> >> I would prefer c) over b) over a) > > Looking at the code again, c) looks feasible after updating > git_snpath() to accept a strbuf instead of buffer/size pair. I agree that this is probably the way to go. We are not trying to avoid PATH_MAX, but static-size array that can overflow. Antoine, -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html