On Wed, Dec 11, 2013 at 12:54 PM, Krzesimir Nowak <krzesimir@xxxxxxxxxxxx> wrote: > Users of validate_* passing "0" might get failures on correct name > because of coercion of "0" to false in code like: > die_error(500, "invalid ref") unless (check_ref_format ("0")); Very minor issue: there is no check_ref_format() after v7; perhaps validate_pathname / is_valid_pathname > Also, the validate_foo subs are renamed to is_valid_foo. is_valid_foo is better than validate_foo IMVHO, though still not perfect (it does some validation, but complete validation is done by git command). > > Signed-off-by: Krzesimir Nowak <krzesimir@xxxxxxxxxxxx> -- Jakub Narebski -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html