John Szakmeister wrote:
> Signed-off-by: John Szakmeister <john@xxxxxxxxxxxxxxx>
> ---
> The gnome-keyring credential backend had a number of coding style
> violations. I believe this fixes all of them.
>
> .../gnome-keyring/git-credential-gnome-keyring.c | 55 ++++++++++------------
> 1 file changed, 25 insertions(+), 30 deletions(-)
>
> diff --git a/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c b/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c
> index 635c96b..1613404 100644
> --- a/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c
> +++ b/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c
> @@ -95,9 +95,9 @@ static const char* gnome_keyring_result_to_message(GnomeKeyringResult result)
>
> static void gnome_keyring_done_cb(GnomeKeyringResult result, gpointer user_data)
> {
> - gpointer *data = (gpointer*) user_data;
> - int *done = (int*) data[0];
> - GnomeKeyringResult *r = (GnomeKeyringResult*) data[1];
> + gpointer *data = (gpointer *) user_data;
> + int *done = (int *) data[0];
> + GnomeKeyringResult *r = (GnomeKeyringResult *) data[1];
No need for these castings, a gpointer is void *, so there's no need to cast them.
--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html