Junio C Hamano wrote: > Yann Dirson <ydirson@xxxxxxxxxx> writes: > >> Currently, running "git-config foo=bar", ie. presumably an erroneous >> attempt at setting "foo", indeed queries "foo=bar", so outputs nothing >> and reports success. >> >> Do we want to allow "=" signs in config var names ? It would seem >> reasonable to refuse them, and report an error to the innocent user >> (OK, i'm not that innocent, but still ;) >> >> Or does that sound a bad idea to anyone ? > > Something like: > > git config remote.origin.fetch=refs/heads/master:refs/heads/origin > git config remote.origin.fetch+=refs/heads/next:refs/heads/next > git config remote.origin.fetch+=+refs/heads/pu:refs/heads/pu > git config remote.origin.fetch+=refs/heads/maint:refs/heads/maint > > sounds sensible. > > However, my feeling is "git repo-config" is primarily for use by > scripts, and we are better off educating users not to be afraid > of viewing and editing .git/config file themselves. I think the question was not if we want new syntax for setting variables, but if we want to disallow '=' in variable (key) names. They are pretty restricted, and I cannot think offhand of variable name we would want that would need to have '=' in it... -- Jakub Narebski Warsaw, Poland ShadeHawk on #git - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html