On Mon, Dec 2, 2013 at 7:18 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Krzesimir Nowak <krzesimir@xxxxxxxxxxxx> writes: >> On Mon, 2013-12-02 at 01:21 +0100, Jakub Narębski wrote: >>> On Thu, Nov 28, 2013 at 12:44 PM, Krzesimir Nowak >>> <krzesimir@xxxxxxxxxxxx> wrote: >>> >>> > Allow @additional_branch_refs configuration variable to tell gitweb to >>> > show refs from additional hierarchies in addition to branches in the >>> > list-of-branches view. >>> > >>> > Signed-off-by: Krzesimir Nowak <krzesimir@xxxxxxxxxxxx> >>> >>> Why not use %feature hash instead of adding new configuration variable? >>> I think that this option is similar enough to 'remote_heads' feature >>> (which BTW should be 'remote-heads'), and could conceveilably enabled >>> on a per-repository basis, i.e. with repository configuration override, >>> isn't it? >> >> I'd like to see some consensus on it before I start changing the patch >> again. > > I missed the remote-heads which is an existing feature when I > commented; if this can be exposed to the users as an extension to > it like Jakub suggests, it may be a better direction. I think that additional-branch-refs (or just branch-refs) is different enough from remote_heads feature (which is about showing "remotes" section in "summary" view, and IIRC adding "remotes" view) that it should be kept separate. On the other hand it is similar enough that I think style of implementation should also be similar, i.e. use %feature hash. IMVHO -- Jakub Narebski -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html