format-patch/log/whatchanged all take --not and --all as options to the internal revlist process. So these should be supported as possible completions. gitk takes anything rev-list/log/whatchanged takes, so we should use complete_revlist to handle its options. Signed-off-by: Shawn O. Pearce <spearce@xxxxxxxxxxx> --- contrib/completion/git-completion.bash | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 3b1f100..466cc32 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -494,6 +494,7 @@ _git_format_patch () --signoff --in-reply-to= --full-index --binary + --not --all " return ;; @@ -532,6 +533,7 @@ _git_log () --author= --committer= --grep= --all-match --pretty= --name-status --name-only + --not --all " return ;; @@ -898,7 +900,7 @@ _gitk () return ;; esac - __gitcomp "$(__git_refs)" + __git_complete_revlist } complete -o default -o nospace -F _git git -- 1.5.0.rc3.22.g5057 - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html