Sergey Sharybin wrote: > On Fri, Nov 22, 2013 at 5:16 PM, Ramkumar Ramachandra > <artagnon@xxxxxxxxx> wrote: >> >> [+CC: Jens, the goto-guy for submodules] >> >> Sergey Sharybin wrote: >> > Namely, `git ls-files -m` will show addons as modified, regardless >> > ignore=all configuration. In the same time `git diff-index --name-only >> > HEAD --` will show no changes at all. >> >> This happens because diff-index handles submodules explicitly (see >> diff-lib.c), while ls-files doesn't (see builtin/ls-files.c). My >> opinion is that this is a bug, and git ls-files needs to be taught to >> handle submodules properly. > > Shall i fire report somewhere or it's being handled by the folks > reading this ML? Bugs are reported and tackled on the list. >> > This leads to issues with Arcanist (which is a Phabricator's tool) who >> > considers addons as uncommited changes and either complains on this or >> > just adds this to commits. >> >> Does Arcanist use `git ls-files -m` to check? > > Yes, Arcanist uses `git ls-files -m` to check whether there're local > modifications. We might also contact phab developers asking to change > it to `git diff --name-only HEAD --`. Is there a preferable way to > get list of modified files and are this command intended to output the > same results? I just checked it out: it uses `git ls-files -m` to get the list of unstaged changes; `git diff --name-only HEAD --` will list staged changes as well. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html