Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > builtin_diff_b_f() needs a path, not pathspec. Other modes in diff > can deal with pathspec just fine. But because of the current > GUARD_PATHSPEC() location, other modes also reject :(glob) and > :(icase). > > Move GUARD_PATHSPEC(), and the "path" assignment statement, which is > the reason of this GUARD_PATHSPEC(), inside builtin_diff_b_f(). > > Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> > --- Makes sense. Let me squash this in. diff --git a/t/t6131-pathspec-icase.sh b/t/t6131-pathspec-icase.sh index 8d4a7fc..a7c7ff5 100755 --- a/t/t6131-pathspec-icase.sh +++ b/t/t6131-pathspec-icase.sh @@ -100,4 +100,10 @@ test_expect_success 'match_pathspec_depth matches :(icase)bar with empty prefix' test_cmp expect actual ' +test_expect_success '"git diff" can take magic :(icase) pathspec' ' + echo FOO/BAR >expect && + git diff --name-only HEAD^ HEAD -- ":(icase)foo/bar" >actual && + test_cmp expect actual +' + test_done Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html