On Wed, Nov 20, 2013 at 01:54:20PM -0500, Jeff King wrote: > I'm not sure why the old $FAKE_EDITOR doesn't work there, though (not > that it would make the test pass anyway, as it does something different > than what the test wants, but I would not expect the shell to complain > of failure). Oh, I see. The original FAKE_EDITOR is: exec grep '^diff --git' "\$1" But the whole point of the test is that we do not have such a "diff" header, being only a submodule update, and so grep exits non-zero, and git thinks the editor has failed. So mystery solved, and the sole problem is the proper setting of the variable. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html